Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TFor #11891

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Remove TFor #11891

merged 3 commits into from
Jan 22, 2025

Conversation

Simn
Copy link
Member

@Simn Simn commented Dec 17, 2024

The TFor typed expression node was originally designed as a high-level construct to allow generators optimization in some circumstances. However, it never really got there and ever since we introduced the analyzer many years ago it has been rewritten to a while-loop anyway. In that light I would like to remove it entirely.

@ncannasse I noticed that this was one of the nodes that remain unchanged in the ctx.allow_transform case. Could you confirm that removing it is alright in that regard?

@skial skial mentioned this pull request Jan 6, 2025
Closed
1 task
@Simn
Copy link
Member Author

Simn commented Jan 21, 2025

@yuxiaomao Could you check if this would cause you guys any problems?

@kLabz kLabz added this to the 5.0 preview 1 milestone Jan 21, 2025
@yuxiaomao
Copy link
Contributor

I've got an error with one of our project (no error with haxe dev 6c42a73; error persist even if I merge 6c42a73 into this PR). I'll send you more details in private.

 ERROR  src/ui/win/BannerCamp.hx:391: lines 391-392

 391 |     for( bonus in Data.item.get(resolution).props.bonuses )
     |
     | Array<Item_props_bonuses>has no field hasNext()

      ->  E:\Projects\shiroTools\haxe\std/haxe/macro/Context.hx:531: characters 10-33

      531 |   return load("type_expr", 1)(e);
          |          ^^^^^^^^^^^^^^^^^^^^^^^
          | Called from here

@Simn Simn merged commit 0b2b0da into development Jan 22, 2025
114 of 115 checks passed
@Simn Simn deleted the remove_TFor branch January 22, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0 preview 1
Development

Successfully merging this pull request may close these issues.
3 participants
@Simn @yuxiaomao @kLabz